bug - modify_state hook should operate on a copy of state #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 92.59% 92.64% +0.04%
==========================================
Files 8 8
Lines 459 462 +3
==========================================
+ Hits 425 428 +3
Misses 34 34
Continue to review full report at Codecov.
|
marcoceppi
force-pushed
the
hook/before-save
branch
4 times, most recently
from
4f2b1a3 to
9caba07
Compare
marcoceppi
changed the title
marcoceppi
force-pushed
the
hook/before-save
branch
from
9caba07 to
cf5f0b8
Compare
kapilt
reviewed
Sep 11, 2020
kapilt
reviewed
Sep 11, 2020
marcoceppi
force-pushed
the
hook/before-save
branch
from
4c183a1 to
7a39fbc
Compare
kapilt
reviewed
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things are addressed in this. The first is what is passed back to the function under test. During replays that's
TerraformTestApiand during live runs it'sTerraformStatewhile functionally both the same thing, we want to make sure we don't leakTerraformStatedirectly to the function under test asTerraformTestApiinterface will likely grow in the future.Second item, if the modify_state hook is implemented in a test run then the modified state is not only written to disk but also returned to the function under test. What should happen is the unmodified state during record / live runs is returned to the function under test and a copy is passed through the modify_state hook before writing to disk.