-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pytest-xdist as dependency #29
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 8 8
Lines 462 462
=======================================
Hits 428 428
Misses 34 34 Continue to review full report at Codecov.
|
do you have pytest-xdist installed and if so what version? |
we probably need to add pytest-xdist to our requires its currently only setup as a dev-dependency |
no did not have pytest-xdist installed |
I had the same experience. Installing python-xdist solved it. Everything was cool after that. Thanks. |
This reverts commit 09cd184.
I just updated this PR to revert the previous change and move pytest-xdist from dev to prod dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this up. Just one request before releasing.
@@ -16,10 +16,10 @@ python = "^3.6" | |||
pytest = "~6.0.0" | |||
jmespath = "^0.10.0" | |||
portalocker = "^1.7.0" | |||
pytest-xdist = ">= 1.31.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we stick with ^1.31.0
? That will do >= 1.31.0 but not 2.0 so we don't accidentally break things if upstream changes faster than we're ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we work on xdist 2.0, and thats already out so we don't want to pin to old versions, we want to catch breakage proactively, we should setup a nightly github action to catch any issues against these pins. the lock file already captures repeatable install per se albeit thats source install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you want me to do here, keep the >=
or switch to ^
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'll take up an item to expand our testing on latest deps for our installs
I installed
pytest-terraform
using a fresh poetry environment, ran a simple testing script, and got this output:When I remove the
worker_id
arg, the tests run