Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Update README and env.sample #1121

Merged
merged 4 commits into from
Jun 15, 2017
Merged

Update README and env.sample #1121

merged 4 commits into from
Jun 15, 2017

Conversation

fureigh
Copy link
Contributor

@fureigh fureigh commented Jun 14, 2017

This PR:

  • Updates the example values in env.sample from [*].cloud.gov to [*].fr.cloud.gov,
  • Updates the recommended GOPATH value and repository locations, as the current instructions are derived from an older version of Go, and
  • Updates the README's listed environments to their new GovCloud locations.

@fureigh fureigh requested a review from jcscottiii June 14, 2017 22:36
@jcscottiii
Copy link
Contributor

thanks! going to rebase with master which has this now

fureigh added 3 commits June 15, 2017 09:26
@fureigh
Update sample env variables from .cloud.gov to .fr.cloud.gov
b594ee4 
Now that we've switched from East-West to GovCloud, the URLs in
this sample env file should use *.fr.cloud.gov instead of
*.cloud.gov.
@fureigh
Update recommended GOPATH value and repository location
3d6e1b5
@fureigh
Update documented environments from .cloud.gov to .fr.cloud.gov
b369dba
@rememberlenny
Copy link
Contributor

Looks good! Im wondering, should we put all of the existing secrets into the env file, and just have empty values for clarity?

@rememberlenny
Copy link
Contributor

rememberlenny commented Jun 15, 2017 •
edited
Loading

For clarity, I have these three secrets that are missing from the env test file:

export SMTP_FROM='no-reply@cloud.gov'
export NEW_RELIC_ID=12345
export NEW_RELIC_BROWSER_LICENSE_KEY=abcdef

cc: @fureigh @jcscottiii

@jcscottiii
Copy link
Contributor

jcscottiii commented Jun 15, 2017 •
edited
Loading

Ahh yeah, let's add those or at least SMTP_FROM since it is required.

@rememberlenny
Copy link
Contributor

Added

@jcscottiii
Copy link
Contributor

waiting for CI to finish

@jcscottiii jcscottiii merged commit 0d0f157 into master Jun 15, 2017
@jcscottiii jcscottiii deleted the rf-update-readme branch June 15, 2017 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcscottiii jcscottiii jcscottiii approved these changes

Assignees
No one assigned
Labels
review-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fureigh @jcscottiii @rememberlenny