Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Email validator in the invite form #1125

Merged
merged 14 commits into from
Jun 22, 2017
Merged

Email validator in the invite form #1125

merged 14 commits into from
Jun 22, 2017

Conversation

rememberlenny
Copy link
Contributor

screen shot 2017-06-21 at 1 55 39 pm

screen shot 2017-06-21 at 1 55 45 pm

@rememberlenny rememberlenny changed the title Lkb email validator Email validator in the invite form Jun 21, 2017
@jcscottiii
Copy link
Contributor

Let's change the wording to "The value entered is not a valid e-mail address."

@jcscottiii
Copy link
Contributor

What about a test of the user invite component? Would be helpful in case the validator was ever renamed or something.

@rememberlenny
Copy link
Contributor Author

@jcscottiii Updated

jcscottiii
jcscottiii reviewed Jun 21, 2017
View reviewed changes
static_src/util/validators.js Outdated
@@ -31,7 +31,19 @@ export function validateString() {
return function _validateString(value, name) {
if (!value || !value.length) {
return {
message: `The ${name || ''} field was not filled out`
message: 'The value entered is not a valid e-mail address'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, i think you changed the message for the other validator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcscottiii Fixed

@rememberlenny
Copy link
Contributor Author

@jcscottiii Finally went green

@jcscottiii jcscottiii merged commit 38669c8 into master Jun 22, 2017
@jcscottiii jcscottiii deleted the lkb-email_validator branch June 22, 2017 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcscottiii jcscottiii jcscottiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rememberlenny @jcscottiii