This repository has been archived by the owner on May 19, 2020. It is now read-only.
Correct validator to use rfc822 email validation #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rememberlenny
force-pushed
the
lkb-email_validation_rfc822
branch
from
aaf28ee to
d80f623
Compare
|
Fixed the tests here. Ready for review. |
el-mapache
reviewed
Jun 23, 2017
static_src/util/validators.js
Outdated
| @@ -41,7 +41,7 @@ export function validateString() { | |||
|
|
|||
| export function validateEmail() { | |||
| return function _validateEmail(value, name) { | |||
| if (!(/^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(value))) { | |||
| if (!(/^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/).test(value)) { | |||
There was a problem hiding this comment.
I might make the regex itself a const outside the function so we don't have to create it each time we call validateEmail. As a bonus it can replace the regexp literal with a readable name!
|
@el-mapache Great point. I just stored this as a variable. |
el-mapache
reviewed
Jun 23, 2017
static_src/util/validators.js
Outdated
| @@ -41,7 +41,8 @@ export function validateString() { | |||
|
|
|||
| export function validateEmail() { | |||
| return function _validateEmail(value, name) { | |||
| if (!(/^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/).test(value)) { | |||
| const emailRegex = /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/; | |||
There was a problem hiding this comment.
We should move this outside the exported function, this will still re-parse the regex every time the function is called. Its not a big deal performance-wise but I think its good practice
There was a problem hiding this comment.
@el-mapache Just moved up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.