-
Notifications
You must be signed in to change notification settings - Fork 18
Add indicator badge when deleting service instance #1159
Conversation
Previously, we didn't give the user any feedback after they clicked the 'confirm delete' button
e983d18
to
935f539
Compare
}; | ||
} | ||
|
||
const propTypes = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this after the imports. (at the top)
* Add function to create and add service instance to reduce duplicate code * Update specs I touched to ES^ to improve code style consistency
935f539
to
3a0fa76
Compare
we need a way to handle the error case of deleting the service. (should turn off _updating). (it's a lot of stuff to add so if you want to make a separate PR, you can do that.) let me know your thoughts. |
@jcscottiii I can add a test to the actions that verifies that the same method is called from both We don't really have any kind of error handling around this action, so I would definitely want to have any of that work in a separate ticket/PR |
@el-mapache that would be really good! |
c394677
to
559eea6
Compare
@jcscottiii Test file updated! |
@el-mapache could you make a card for taking care of the error handling in a separate PR? (you can put it in for this sprint) |
@jcscottiii Definitely! |
Previously, we didn't give the user any feedback after they clicked the
'confirm delete' button.
Handy gif reference: