Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Revert "[Snyk] Fix for 10 vulnerable dependency paths" #1201

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

jcscottiii
Copy link
Contributor

@jcscottiii jcscottiii commented Aug 23, 2017

Reverts #1167

This will fix the failing go tests

Recently snyk (which is a js based project) has updated and added Go code. As a result, when go lists all the packages, it will correctly look in the node_modules) As a result, go will fail stuff everywhere in there.

We don't use snyk so we can just revert this.

Related commits:
snyk/cli@e36ba8f6#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R48

Look at highlighted stuff
image

Copy link
Contributor

@rememberlenny rememberlenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching

@rememberlenny rememberlenny merged commit 05db2c1 into master Aug 23, 2017
@rememberlenny rememberlenny deleted the revert-1167-snyk-fix-82eeeff3 branch August 23, 2017 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants