This repository has been archived by the owner on May 19, 2020. It is now read-only.
Fix display button on multi param plans #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the service list used to determine which button text to show depending on the service name. This was fine for cdn-route because the service name was the same as the service plan. However it didn't work for the others. This commit just fixes the list to filter on
rememberlenny
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the service list used to determine which button text to show
depending on the service name. This was fine for cdn-route because the
service name was the same as the service plan. However it didn't work
for the others.
This commit just fixes the list to filter on
Example of what was happening before:
