This repository has been archived by the owner on May 19, 2020. It is now read-only.
Use a more idiomatic React outlet #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathaningram
force-pushed
the
ji-more-idiomatic-react-outlet
branch
from
7c4fb24 to
f6f9aab
Compare
el-mapache
approved these changes
Oct 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in CRA-generated apps (https://github.com/facebookincubator/create-react-app) and most React apps.
Also, while it's not a bottleneck (and going into micro optimisation territory), I suspect that
document.getElementByIdis much more performant thandocument.querySelector. Still, the idiomaticity is nice.