This repository has been archived by the owner on May 19, 2020. It is now read-only.
Add ability to skip tests that require Docker #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure that test breakage is actually unrelated to this change, however I'll note the irony that the test that failed has failed due to a Docker issue, which would have been skipped if the flag that this patch introduces had been enabled. I'll push the same patch a 2nd time, to trigger another build to see if that was just a temporary flakiness or not. |
Set env variable SKIP_DOCKER=1 to skip tests that require Docker. Why? In some CI environments it is problematic to allow Docker containers to be created, this change gives the operator the choice to accept the risk of these tests failing.
aeijdenberg
force-pushed
the
skipdocker
branch
from
88d6f90 to
7989cc9
Compare
jcscottiii
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set env variable SKIP_DOCKER=1, and then tests that require Docker are skipped.
Why? In some CI environments it is problematic to allow Docker containers to be created, this change gives the operator the choice to accept the risk of these tests failing.