This repository has been archived by the owner on May 19, 2020. It is now read-only.
Make breadcrumbs component dumb #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathaningram
force-pushed
the
ji-breadcrumbs
branch
2 times, most recently
from
66f9b93 to
96be934
Compare
jcscottiii
reviewed
Oct 12, 2017
| import { appPropType } from '../../stores/app_store'; | ||
| import { orgPropType } from '../../stores/org_store'; | ||
| import { spacePropType } from '../../stores/space_store'; | ||
| import Item from './breadcrumbs_item'; |
There was a problem hiding this comment.
Let's keep the name the same as what's in the imported file.
Item -> BreadcrumbsItem
There was a problem hiding this comment.
@jcscottiii I was just trying to remove some stutter but I do concede that keeping BreadcrumbsItem makes searching easier (just at the expense of stutter) - but all good, I will update.
jcscottiii
reviewed
Oct 12, 2017
static_src/stores/org_store.js
Outdated
| @@ -1,15 +1,16 @@ | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
is there a reason you got rid of this?
There was a problem hiding this comment.
@jcscottiii I will revert - I just removed it because it didn't really tell us anything we don't already know: org_store.js is a store for org data :)
jcscottiii
suggested changes
Oct 12, 2017
This also fixes the "calling setState on an unmounted component" warning. Also, instead of using CSS classes to target DOM nodes in integration tests, we use `data-test` attributes. We can later strip these out of the build using a babel plugin, if desired. Note: there are other ways of doing this, but for the time being the `data-test` attribute best matches the current code with the least number of changes and is clear enough. It's also a recommended approach by Kent C Dodds, if that holds any weight.
jonathaningram
force-pushed
the
ji-breadcrumbs
branch
from
96be934 to
7d9f566
Compare
Thanks so much for your review - changes made, ready for review again. |
jcscottiii
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the "calling setState on an unmounted component"
warning.
Also, instead of using CSS classes to target DOM nodes in integration
tests, we use
data-testattributes. We can later strip these out ofthe build using a babel plugin, if desired. Note: there are other ways
of doing this, but for the time being the
data-testattribute bestmatches the current code with the least number of changes and is clear
enough. It's also a recommended approach by Kent C Dodds, if that holds
any weight.