Add documentation around removing a user from an organization or space #977

rememberlenny · 2017-07-21T05:06:09Z

Feel free to directly make changes to this pull request.

…he dashboard/cli

rememberlenny · 2017-07-21T05:10:59Z

This PR adds documentation that is reference by cloud-gov/cg-dashboard#1163

fureigh · 2017-07-21T17:38:54Z

content/docs/apps/managing-teammates.md

+
+{{% dashboard %}}
+
+### Organization Users


@rememberlenny I'll push a commit that lowercases users here and in the next headline — holler if you'd rather I not.

Sounds good!

fureigh · 2017-07-21T22:52:16Z

content/docs/apps/managing-teammates.md

+4. Remove the user for each combination of space and role, by running:
+
+    ```sh
+    cf unset-space-role <email> <org> <space> <role>


Safe to assume the username will always be an email address? email and username are functionally equivalent at the moment but conceivably might not always be. (Same question applies in line 128.)

It's already used elsewhere in this file, so not necessary to discuss at the moment.

For regular users, it's safe to assume it will always be user's e-mail address. For specially created users like the brokered accounts, it would be weird things (in that a UAA UUID)

fureigh · 2017-07-21T22:52:47Z

content/docs/apps/managing-teammates.md

+
+If you're an Org Manager or Space Manager, go to the space with the teammate you want to remove.
+
+On the Space page, scroll down to the "Space users" section. This has a list of all the space users. Click the "Remove User From Space" button.


@rememberlenny this currently doesn't exist on the Space users page.

fureigh

One question (re: who has access to the dashboard). All else looks good. Thanks!

fureigh · 2017-07-21T23:08:50Z

content/docs/apps/managing-teammates.md

+
+If you are an Org Manager or Space Manager, you can remove teammates from orgs and spaces respectively.
+
+{{% dashboard %}}


Do Space Managers have access to the dashboard? I ask because of line 22.

@fureigh Org Managers are currently the only people who can invite users. The reference on line 22 is still correct. All users have access to the dashboard. There is a ticket that Adam is working on that would require a change to the documentation. In regards to my PR that adds the remove user functionality/notice, this is correct.

jcscottiii

Not sure what you want to do about the space users page.

gboone

When I grow up I want to be a space manager. Sounds like a cool job. Joking aside, this looks good from my end. I trust the team to work out @fureigh and @jcscottiii's questions. LMK if you want a review again once you're set or if you want my help figuring out how to resolve them.

brittag · 2017-07-25T02:57:56Z

This will be very helpful! Recommendations:

Look for and cut unnecessary sentences and words, since this is a long page and people want to get to their task. Example: "On the Organization page, scroll down to the “Organization users” section. This has a list of all the organization users." -> "On the Organization page, go down to “Organization users”."
Speak to the user consistently as "you": "they must first be removed from any of the organization’s spaces first" -> "you first need to remove them from the organization's spaces".

… lkb-remove_user

Requested changes have been addressed

rememberlenny added 2 commits July 21, 2017 01:05

Add image to show the remove user from org button

2fb0b54

Add instructions around how to remove users from org/spaces through t…

df7e103

…he dashboard/cli

rememberlenny requested a review from fureigh July 21, 2017 05:06

rememberlenny mentioned this pull request Jul 21, 2017

Add error message when Space user exists on Org user removal. cloud-gov/cg-dashboard#1163

Merged

rememberlenny requested a review from gboone July 21, 2017 05:10

rememberlenny requested a review from suprenant July 21, 2017 16:46

fureigh reviewed Jul 21, 2017

View reviewed changes

Lowercase 'users' per style guide

0f1cddb

fureigh reviewed Jul 21, 2017

View reviewed changes

fureigh previously requested changes Jul 21, 2017

View reviewed changes

jcscottiii reviewed Jul 24, 2017

View reviewed changes

gboone previously approved these changes Jul 24, 2017

View reviewed changes

rememberlenny added 2 commits July 25, 2017 12:06

Similify copy and make it active

1b6d2c6

Merge branch 'lkb-remove_user' of https://github.com/18F/cg-site into…

dcd27da

… lkb-remove_user

rememberlenny dismissed gboone’s stale review via dcd27da July 25, 2017 16:06

suprenant approved these changes Jul 25, 2017

View reviewed changes

rememberlenny merged commit d20443d into master Jul 25, 2017

rememberlenny deleted the lkb-remove_user branch July 25, 2017 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add documentation around removing a user from an organization or space #977

Add documentation around removing a user from an organization or space #977

rememberlenny commented Jul 21, 2017 •

edited

Loading

rememberlenny commented Jul 21, 2017

fureigh Jul 21, 2017

rememberlenny Jul 21, 2017

fureigh Jul 21, 2017

fureigh Jul 21, 2017

jcscottiii Jul 24, 2017

fureigh Jul 21, 2017

jcscottiii Jul 24, 2017

fureigh left a comment

fureigh Jul 21, 2017

rememberlenny Jul 22, 2017

jcscottiii left a comment

gboone left a comment •

edited

Loading

brittag commented Jul 25, 2017 •

edited

Loading


		If you're an Org Manager or Space Manager, go to the space with the teammate you want to remove.

		On the Space page, scroll down to the "Space users" section. This has a list of all the space users. Click the "Remove User From Space" button.


		If you are an Org Manager or Space Manager, you can remove teammates from orgs and spaces respectively.

		{{% dashboard %}}

Add documentation around removing a user from an organization or space #977

Add documentation around removing a user from an organization or space #977

Conversation

rememberlenny commented Jul 21, 2017 • edited Loading

rememberlenny commented Jul 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fureigh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcscottiii left a comment

Choose a reason for hiding this comment

gboone left a comment • edited Loading

Choose a reason for hiding this comment

brittag commented Jul 25, 2017 • edited Loading

rememberlenny commented Jul 21, 2017 •

edited

Loading

gboone left a comment •

edited

Loading

brittag commented Jul 25, 2017 •

edited

Loading