generated from cloud-gov/.github
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use middleware to add nonce and CSP headers #553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hursey013
force-pushed
the
bh-csp-headers
branch
from
October 23, 2024 14:40
fcc90bf
to
26767ae
Compare
echappen
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of this work, Brian, I really like the separation of concerns this approach takes. There are some concepts which I'd like to better understand before I approve. LMK if a chat would be better.
hursey013
force-pushed
the
bh-csp-headers
branch
from
October 31, 2024 17:09
da969cd
to
c21b4b2
Compare
hursey013
force-pushed
the
bh-csp-headers
branch
from
October 31, 2024 17:35
c21b4b2
to
670174a
Compare
hursey013
force-pushed
the
bh-csp-headers
branch
from
November 1, 2024 17:06
c1cd452
to
2681bb8
Compare
echappen
approved these changes
Nov 1, 2024
hursey013
added a commit
that referenced
this pull request
Nov 1, 2024
Use middleware to add nonce and CSP headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Next/Image
to remove inline stylesRelated issues
https://www.58bits.com/blog/chaining-or-combining-nextjs-middleware
https://nextjs.org/docs/app/building-your-application/configuring/content-security-policy
https://github.com/vercel/next.js/tree/canary/examples/with-strict-csp
vercel/next.js#45184
Submitter checklist
Security considerations
None