Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build our custom csb image, with brokerpaks included #78

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Build our custom csb image, with brokerpaks included #78

merged 1 commit into from
Mar 22, 2024

Conversation

jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

Related to cloud-gov/product#2943
Related to cloud-gov/csb#1

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None.

@jameshochadel jameshochadel requested a review from a team March 22, 2024 13:43
@jameshochadel jameshochadel merged commit 8d74d2a into main Mar 22, 2024
@jameshochadel jameshochadel deleted the csb-custom branch March 22, 2024 14:07
@jameshochadel jameshochadel restored the csb-custom branch March 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdboyd markdboyd markdboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameshochadel @markdboyd