Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding autoscaler client #771

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Adding autoscaler client #771

merged 1 commit into from
Sep 26, 2023

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Sep 25, 2023

Changes proposed in this pull request:

  • This adds the autoscaler client to UAA used by CF in dev/stage/prod
  • Password is dynamically created and managed by the environment level credhub.

security considerations

Password is dynamically created and managed by the environment level credhub. The credhub value (with full path) will be used in ops files for autoscaler

@cweibel cweibel requested a review from a team September 25, 2023 20:31
ChrisMcGowan
ChrisMcGowan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ChrisMcGowan ChrisMcGowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For autoscaler

@cweibel cweibel merged commit e91e6c2 into main Sep 26, 2023
1 check passed
@cweibel cweibel deleted the autoscaler branch September 26, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cweibel @ChrisMcGowan