Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have isolation segment configuration use names #867

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Have isolation segment configuration use names #867

merged 5 commits into from
Jun 27, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Jun 27, 2024

Changes proposed in this pull request:

  • Using names instead of incremental counter to allow for easier deletion of isolation segments
  • Will update internal-docs separately with new maintenance mechanism
  • Credhub variables are set, but commented out in pipeline.yml, not allowed to use empty strings in credhub variables. Once this feature is used, remove the hard coded "" and use the credhub variable currently comment out for ISO_SEG_NAMES
  • Part of IP: Rework how platform diego cells are templated product#3024

security considerations

None

@cweibel cweibel requested a review from a team as a code owner June 27, 2024 18:55
@cweibel cweibel merged commit 562999e into main Jun 27, 2024
1 check passed
@cweibel cweibel deleted the platformcell10 branch June 27, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cweibel @ChrisMcGowan