Document purpose of terraform-yaml resource in terraform jobs #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcgottlieb
previously approved these changes
Oct 10, 2024
bengerman13
previously approved these changes
Oct 10, 2024
|
It looks like it's there to trigger the terraform plan jobs if there's been a change in the tf state file for each deployment |
|
@dandersonsw Aha. Let me make sure I understand. These resources watch the state bucket for changes. When there's an update, it triggers the job. The resource itself is not an input to any step, just a trigger. The job then gets the state through an independent method — the standard Sound right? If yes, I'll add a little comment, since this managed to trick several of us. Thanks! |
This reverts commit 5df7222.
|
@jameshochadel That is correct, as far as I can tell the only purpose of that resource is to act as a trigger when there's been a change |
See conversation on #911
jameshochadel
dismissed stale reviews from bengerman13 and rcgottlieb
via
7edac93
jameshochadel
changed the title
dandersonsw
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
I think this input is unused. If an operator knows why it's there, let me know and I'll keep it, and add a comment explaining its purpose. In the deploy-cf jobs, it's used by theterraform-secretssteps, but I cannot find any step that takes it as an input in the terraform jobs.security considerations
None. Removing unused code.