Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Upgrade hapi to 16.6.0 #54

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Upgrade hapi to 16.6.0 #54

merged 1 commit into from
Sep 21, 2017

Conversation

jseppi
Copy link
Contributor

@jseppi jseppi commented Sep 21, 2017

and all its submodules, including content, to fix a regex dos issue (ref #53)

@jseppi jseppi self-assigned this Sep 21, 2017
@jseppi jseppi requested a review from jmhooper September 21, 2017 16:12
and all its submodules, including `content`, to fix a regex dos issue
@jseppi jseppi force-pushed the 53-upgrade-hapi-content branch from 2c7bcc7 to 2f45314 Compare September 21, 2017 16:13
@jseppi
Copy link
Contributor Author

jseppi commented Sep 21, 2017

Interestingly, I couldn't just do yarn upgrade hapi to get the upgraded content module, which is actually a sub-sub-depedency. It's immediate parent is subtext. subtext just specifies content version 3.x.x and we needed 3.0.6 specifically.

To get the newest version, I had to do yarn remove hapi && yarn add hapi, which removed and re-added the entire hapi dependency tree.

There's an issue about this behavior over at yarn: yarnpkg/yarn#2394

@wslack
Copy link

wslack commented Sep 21, 2017

Let's go ahead and push this to prod @jseppi.

@jseppi jseppi merged commit 2835caf into staging Sep 21, 2017
@jseppi jseppi deleted the 53-upgrade-hapi-content branch September 21, 2017 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants