Cleanup layout.ld #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Richey <joerichey@google.com>
We are currently using a mixture of tabs and spaces, this is silly. Signed-off-by: Joe Richey <joerichey@google.com>
This was just copied over, but isn't necessary. The only data this removes is the `.comment` section, but it's fine (and even desireable) to leave that in. Signed-off-by: Joe Richey <joerichey@google.com>
rbradford
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #41 (to fix the CI).
Right now the linker script uses a mixture of tabs and spaces for indentation, switch to using all spaces.
Also, we remove the
/DISCARD/section taken from EDK2. There's not a good reason to have this section (it's purpose is very EDK2 specific). In fact, it can often hide section/linking bugs by removing code that we actually want to be in the final binary.We keep the
/DISCARD/section that handles stripping symbols and symbol tables from the binary. Eventually, we will just use Cargo'sstripoption (see rust-lang/cargo#8246) to handle this instead of having it in the linker script. This will allow us to strip symbols inreleasemode and keep them indebugmode.