This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Iteration over all pages in a collection #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter (correct) failure messages
…(there seems to be some kind of interference between objects)
…ssing (simulated) objects
…*all* pages are crawled or if the collection stops in the middle
…each other (as the state of the pagination changes)
…ed with @BeforeMethod it is executed before *every* test
…re is a next page via hasNext(), avoid an additional HTTP request whenever possible
…allows streaming over *all* objects on *all* pages)
|
Remarks from latest Review have been addressed. Can be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a
stream()method that allows to iterate over all pages of a collection.The pagination is performed automatically in the background, only required pages are fetched via API call.
Additionally, the performance of paging has been improved in general (fixes #72).
The new
stream()method is provided by the classIterableObjectPagination. All collections have been updated to inherit from that class.The previous base class
JsonArrayPaginationstill exists and its behavior was not changed, so this pull request should be completely backward compatible.