Skip to content

Commit

Permalink
Maintenance update (#174)
Browse files Browse the repository at this point in the history
This PR will increase coverage and other small things

* fixed "notes" coverage
* Oracle CI Action optimized from 10 min down to 5 min
* fixed ui_file_actions, ui_top_menu coverage

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
  • Loading branch information
bigcat88 authored Dec 8, 2023
1 parent 4aa52a5 commit 9f16443
Show file tree
Hide file tree
Showing 6 changed files with 1,251 additions and 59 deletions.
2 changes: 1 addition & 1 deletion .github/.codecov.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
codecov:
notify:
after_n_builds: 9
after_n_builds: 11

comment:
require_changes: true
Expand Down
42 changes: 19 additions & 23 deletions .github/workflows/analysis-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -357,16 +357,10 @@ jobs:
path: data/nextcloud.log
if-no-files-found: warn

tests-oci:
tests-stable27-oci:
needs: [analysis]
runs-on: ubuntu-22.04
name: ${{ matrix.nextcloud }} • 🐘${{ matrix.php-version }} • 🐍${{ matrix.python }} • OCI
strategy:
fail-fast: false
matrix:
nextcloud: [ "27.1.4" ]
python: [ "3.11" ]
php-version: [ "8.2" ]
name: stable27 • 🐘8.1 • 🐍3.11 • OCI

services:
oracle:
Expand All @@ -387,28 +381,30 @@ jobs:
- name: Set up php
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
php-version: '8.1'
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, \
posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, oci8

- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python }}
python-version: '3.11'

- name: cache-nextcloud
id: nextcloud_setup
uses: actions/cache@v3
- name: Checkout server
uses: actions/checkout@v4
with:
path: nextcloud-${{ matrix.nextcloud }}.tar.bz2
key: ${{ matrix.nextcloud }}
submodules: true
repository: nextcloud/server
ref: 'stable27'

- name: Download Nextcloud
if: steps.nextcloud_setup.outputs.cache-hit != 'true'
run: wget -q https://download.nextcloud.com/server/releases/nextcloud-${{ matrix.nextcloud }}.tar.bz2
- name: Checkout Notifications
uses: actions/checkout@v4
with:
repository: nextcloud/notifications
ref: 'stable27'
path: apps/notifications

- name: Set up Nextcloud
run: |
tar -xjf nextcloud-${{ matrix.nextcloud }}.tar.bz2 --strip-components 1
mkdir data
php occ maintenance:install --verbose --database=oci --database-name=XE \
--database-host=127.0.0.1 --database-port=1521 --database-user=useroracle --database-pass=userpassword \
Expand Down Expand Up @@ -457,15 +453,15 @@ jobs:
- name: HTML coverage to artifacts
uses: actions/upload-artifact@v3
with:
name: coverage_oci_${{ matrix.nextcloud }}_${{ matrix.python }}_${{ matrix.php-version }}
name: coverage_oci_stable27_3.11_8.1
path: nc_py_api/htmlcov
if-no-files-found: error

- name: Upload report to Codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
name: coverage_oci_${{ matrix.nextcloud }}_${{ matrix.python }}_${{ matrix.php-version }}
name: coverage_oci_stable27_3.11_8.1
file: coverage.xml
fail_ci_if_error: true
verbose: true
Expand All @@ -475,7 +471,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v3
with:
name: nc_log_oci_${{ matrix.nextcloud }}_${{ matrix.python }}_${{ matrix.php-version }}
name: nc_log_oci_stable27_3.11_8.1
path: data/nextcloud.log
if-no-files-found: warn

Expand Down Expand Up @@ -931,7 +927,7 @@ jobs:
permissions:
contents: none
runs-on: ubuntu-22.04
needs: [tests-maria, tests-pgsql, tests-oci, tests-latest-maria, test-latest-pgsql, tests-client-sqlite]
needs: [tests-maria, tests-pgsql, tests-stable27-oci, tests-latest-maria, test-latest-pgsql, tests-client-sqlite]
name: Tests-OK
steps:
- run: echo "Tests passed successfully"
Loading

0 comments on commit 9f16443

Please sign in to comment.