Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for future SharesAPI #42

Merged
merged 4 commits into from
Jul 24, 2023
Merged

initial commit for future SharesAPI #42

merged 4 commits into from
Jul 24, 2023

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Jul 24, 2023

Before developing sharing api, need to implement bridge between shares permissions which is int and filesystem permissions which type is str, so it is first task.

  • Unify FilesAPI and SharesAPI permissions
  • Implement creating, deleting, listing SharesAPI
  • Wrote tests for creating, deleting, listing SharesAPI
  • Wrote docstrings for what parameters mean in each method.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #42 (33c30de) into main (e3c5b80) will decrease coverage by 2.06%.
The diff coverage is 81.11%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   97.97%   95.92%   -2.06%     
==========================================
  Files          19       20       +1     
  Lines        1134     1275     +141     
==========================================
+ Hits         1111     1223     +112     
- Misses         23       52      +29     
Impacted Files Coverage Δ
nc_py_api/users_status.py 100.00% <ø> (ø)
nc_py_api/weather_status.py 100.00% <ø> (ø)
nc_py_api/files.py 93.13% <57.69%> (-2.99%) ⬇️
nc_py_api/files_sharing.py 76.81% <76.81%> (ø)
nc_py_api/__init__.py 100.00% <100.00%> (ø)
nc_py_api/constants.py 100.00% <100.00%> (ø)
nc_py_api/nextcloud.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Contributor Author

Sharing API is in minimal stage, will return to it later, will merge this as it is.

@bigcat88 bigcat88 merged commit 707f1f1 into main Jul 24, 2023
10 of 11 checks passed
@bigcat88 bigcat88 deleted the shares-api branch July 24, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant