Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

import_tasks instead of include; bringing role up to ansible-prometheus standards; minor changes #48

Merged
merged 4 commits into from
Jul 15, 2018

Conversation

paulfantom
Copy link
Member

[minor] modification to introduce some of good ideas seen in #47 and ansible-prometheus

  • add ansible_managed info to service file
  • use import_tasks instead of include
  • specify become: true on role level not on playbook level
  • split main.yml into smaller files: install.yml and configure.yml
  • use one task for installing dependecies
  • use vars files for distro-specific values
  • use node_exporter_system_group and node_exporter_system_user which shouldn't be user-defined (defined in vars not in defaults), but simplify role management
  • add tags
  • add 2 more preflight checks

@paulfantom paulfantom requested a review from SuperQ July 14, 2018 14:59
@paulfantom paulfantom changed the title Decoupling import_tasks instead of include and bringing role up to ansible-prometheus standards Jul 14, 2018
@paulfantom paulfantom changed the title import_tasks instead of include and bringing role up to ansible-prometheus standards import_tasks instead of include; bringing role up to ansible-prometheus standards Jul 14, 2018
@paulfantom paulfantom added the enhancement New feature or request label Jul 14, 2018
@paulfantom paulfantom changed the title import_tasks instead of include; bringing role up to ansible-prometheus standards import_tasks instead of include; bringing role up to ansible-prometheus standards; minor changes Jul 14, 2018
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulfantom paulfantom merged commit 212db9f into master Jul 15, 2018
@paulfantom paulfantom deleted the decoupling branch July 15, 2018 18:54
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants