let a client accept external client_args #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlhoerberg
requested changes
Dec 4, 2023
|
@carlhoerberg wdyt, ready or not? |
spuun
reviewed
Jan 16, 2024
This record introduces two new client properties, product_version and platform_version which are supposed to replace version
kickster97
force-pushed
the
client_args
branch
from
940b359 to
e5a820e
Compare
kickster97
force-pushed
the
client_args
branch
from
5288b82 to
ef6cca8
Compare
kickster97
requested review from
carlhoerberg
and removed request for
carlhoerberg
src/amqp-client/connection.cr
Outdated
| platform: "Crystal", | ||
| version: AMQP::Client::VERSION, | ||
| capabilities: Arguments.new({ | ||
| connection_name: name || connection_information.name, |
There was a problem hiding this comment.
can the name assigment be done earlier, so that this method don't have to receive both arguments, just the ConnectionInformation with name set?
There was a problem hiding this comment.
Put it before right before start() now
carlhoerberg
approved these changes
Feb 15, 2024
|
@kickster97 make to always squash PRs, don't merge the whole PR commit history with main. Now we have "format", "fix" etc in the main commit history. |
Yes ofc! my mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets amqp-client be able to take in external client arguments so it can present more accurate client information for connections.
In the image below we see it states amqp-client instead of LavinMQ.
If it was RabbitMQ, it would state RabbitMQ so assuming that is the standard