Use DirectDispatcher for logging #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorerlingsson
changed the title
viktorerlingsson
changed the title
spuun
reviewed
Dec 29, 2023
carlhoerberg
requested changes
Jan 5, 2024
carlhoerberg
approved these changes
Jan 9, 2024
carlhoerberg
reviewed
Jan 9, 2024
viktorerlingsson
changed the title
…hats happening during startup
Co-authored-by: Carl Hörberg <carl@84codes.com>
Co-authored-by: Carl Hörberg <carl@84codes.com>
viktorerlingsson
force-pushed
the
yield_during_delete_unused_segments
branch
from
7915f9d to
ae21364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Sets up DirectDispatcher for logging so we always log directly, without manually having to yield Fibers.
Also adds more logging to the startup procedure, making it more verbose.
Relates to the bug that was fixed in #565
https://trello.com/c/FUxNAzYu/402-no-logs-during-startup
HOW can this pull request be tested?
Manual for now