Publish to exchange #786
Merged
Publish to exchange #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
reviewed
Sep 22, 2024
|
@spuun @carlhoerberg any thoughts about always including "default" exchange when getting bindings for a queue heere: https://github.com/cloudamqp/lavinmq/blob/publish-to-exchange/src/lavinmq/vhost.cr#L286 |
snichme
force-pushed
the
publish-to-exchange
branch
from
f376f8a to
f2e3189
Compare
|
Im fine with that |
snichme
requested review from
kickster97 and
viktorerlingsson
as code owners
spuun
reviewed
Sep 30, 2024
|
@spuun agree, early return is nicer. Fixed all now I thinkg |
spuun
reviewed
Oct 1, 2024
snichme
force-pushed
the
publish-to-exchange
branch
from
f55e03a to
c5e4c9a
Compare
|
Specs fails because of this: cloudamqp/amqp-client.cr#48 |
snichme
force-pushed
the
publish-to-exchange
branch
2 times, most recently
from
2f9392c to
c107036
Compare
kickster97
approved these changes
Oct 9, 2024
carlhoerberg
reviewed
Oct 9, 2024
carlhoerberg
reviewed
Oct 9, 2024
carlhoerberg
reviewed
Oct 9, 2024
snichme
force-pushed
the
publish-to-exchange
branch
from
0e7cd21 to
27f4268
Compare
snichme
force-pushed
the
publish-to-exchange
branch
from
27f4268 to
52e261a
Compare
carlhoerberg
approved these changes
Oct 13, 2024
src/lavinmq/exchange/exchange.cr
Outdated
Comment on lines
193
to
197
| when Queue | ||
| queues.add(d) unless d.closed? | ||
| when Exchange | ||
| d.find_queues(routing_key, headers, queues, exchanges) | ||
| end |
There was a problem hiding this comment.
Suggested change
| when Queue | |
| queues.add(d) unless d.closed? | |
| when Exchange | |
| d.find_queues(routing_key, headers, queues, exchanges) | |
| end | |
| in Queue | |
| queues.add(d) unless d.closed? | |
| in Exchange | |
| d.find_queues(routing_key, headers, queues, exchanges) | |
| end |
Co-authored-by: Carl Hörberg <carl@84codes.com>
Co-authored-by: Carl Hörberg <carl@84codes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Move the logic of publishing a message to an exchange from Vhost to the exchange.
The idea came because of the need for the exchange to handle the messages differently for MQTT support
but it has additional benefits like
@queue_bindingsand@exchange_bindingscan have different types and as you may see I've used only one "bindings" for both queue and exchange. for example for FanoutExchange it's just a@bindings : Set(Destination)There is probably some more things that should move down to each subclass to make the code clearer and to support the different types that
@bindingshas now.HOW can this pull request be tested?
specs