Make Launcher the starting point in all cases #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
commented
Jan 14, 2025
| if @config.clustering? | ||
| etcd = Etcd.new(@config.clustering_etcd_endpoints) | ||
| @runner = controller = Clustering::Controller.new(@config, etcd) | ||
| @replicator = Clustering::Server.new(@config, etcd, controller.id) |
There was a problem hiding this comment.
I think we should make Clustering::Server accept a Clustering::Controller instead of etcd and id, and then add methods to Clustering::Controller to handle cluster secret and isr. That would isolate all etcd code to Clustering::Controller.
There was a problem hiding this comment.
ok, but you would like to do that in another PR or?
carlhoerberg
approved these changes
Jan 14, 2025
carlhoerberg
approved these changes
Jan 15, 2025
Co-authored-by: Carl Hörberg <carl@84codes.com>
spuun
force-pushed
the
refactor-upstart
branch
from
df134c0 to
5b64cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
After other refactoring lavinmq no longer released its leader lease on graceful shutdown. The problem was that
Launcherhandled the signal, but didn't have a reference toClustering::Controlleror theLeadership, and therefore couldn't release the lease.When looking into different solutions I realized that we had two ways of starting lavinmq:
LauncherandClustering::Controller.This PR will refactor the upstart to make
Launcherresponsible for the upstart. This also makes launcher the signal handler instead of having this in bothLauncherandClustering::Client.Launcherwill now have a reference toClustering::Controllerinstead of the other way around.HOW can this pull request be tested?
Specs still passes, but some things needs to be tested manually.