Keep Etcd dependencies to Clustering::Controller
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @isr_key = "#{@config.clustering_etcd_prefix}/isr" | ||
| end | ||
|
|
||
| def password : String |
There was a problem hiding this comment.
this can/will only be called by the leader? otherwise we have a racecondition in this method.
There was a problem hiding this comment.
Yes. The Clustering::Client is created by the Clustering::Controller and the password is passed as constructor argument. Clustering::Client doesn't know about neither Etcd nor Clustering::Controller.
Maybe Clustering::Server should be created by Clustering::Controller too. Then #password wont have to be public and Clustering::Controller handles it all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Tiny refactor to move all
Etcdactions toClustering::Controller.HOW can this pull request be tested?
Specs