Setup asdf and direnv managed development environment #44

iilyak · 2021-11-05T13:25:38Z

Now cd into the project directory would activate correct versions of build
dependencies.

Sorry for cleaning up the trailing spaces in README.md. My editor does that by default.

tonysun83 · 2021-11-06T00:08:57Z

Seems test cases are having issues connecting with clouseau during mvn test phase:

java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:741)
	at org.jboss.netty.channel.socket.nio.NioClientSocketPipelineSink$Boss.connect(NioClientSocketPipelineSink.java:401)
	at org.jboss.netty.channel.socket.nio.NioClientSocketPipelineSink$Boss.processSelectedKeys(NioClientSocketPipelineSink.java:370)
	at org.jboss.netty.channel.socket.nio.NioClientSocketPipelineSink$Boss.run(NioClientSocketPipelineSink.java:292)
	at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
	at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44)
	at overlock.threadpool.ErrorLoggedThread.run(NamedThreadFactory.scala:40)

jaydoane

I would like to see this land. Do you have any desire to rebase and update?

jaydoane · 2023-11-10T20:03:12Z

.envrc

@@ -0,0 +1,3 @@
+use asdf
+watch_file ".asdf"
+dotenv_if_exists .envrc.local


At one point, I had to add this get clouseau working:

export MAVEN_OPTS=-Dhttps.protocols=TLSv1,TLSv1.1,TLSv1.2

Do you not find that necessary? If so, is this the file to include it?

It is not needed. The maven central no longer supports TLSv1x so this workaround no longer works.

https://central.sonatype.org/faq/tls-info/

This was needed to convince maven to use old version of TLS because old java versions didn't have support for modern TLS versions in their http client library. The zulu distribution used in this setup backported modern TLS support to java 7.48 (used here).

jaydoane · 2023-11-10T21:25:07Z

Makefile

+.PHONY: clouseau1
+# target: clouseau1 - Start local inistance of clouseau1 node
+clouseau1: .asdf
+	@mvn scala:run -Dlauncher=$@


Has this recently changed to require explicitly setting the Erlang distribution cookie?

The Erlang cookie is now optional for Clouseau. It is the launcher interface that has changed. It should say something like: mvn scala:run -Dname=clouseau1.

However, I think it could be beneficial to let the user to set the cookie still if that is needed (for example, CouchDB uses its own cookie and the default from ~/.erlang.cookie). This can be done by using the with-cookie launcher.

mvn scala:run -Dlauncher=with-cookie -Dname=clouseau1 -Dcookie=brumbrum

Cookie support is implemented in 8099855

Now `cd` into the project directory would activate correct versions of build dependencies.

iilyak · 2023-11-20T19:54:04Z

README.md

 ## Configuration options
-This guide explains the various clouseau configuration options available, and how to use them to tune clouseau performance and scalability. There are two categories of clouseau options, first category is about tuning the JVM (ex: Xmx) and other category of options that go into clouseau.ini. 
+This guide explains the various clouseau configuration options available, and how to use them to tune clouseau performance and scalability. There are two categories of clouseau options, first category is about tuning the JVM (ex: Xmx) and other category of options that go into clouseau.ini.


I am sorry my editor removes trailing spaces. I can "fix it" if it is an issue.

This is a good thing, I do not think we should worry about that.

jaydoane

Tested make targets:

clean
build
clouseau1

and all work as expected. Nicely done!

One small issue, during make build it logs this line:

[INFO] Dependency-reduced POM written at: /Users/jay/repos/clouseau/dependency-reduced-pom.xml

Should dependency-reduced-pom.xml be added to .gitignore?

iilyak · 2023-11-21T02:59:09Z

@pgj Would it negatively impact your work on CI if I merge it?

.tool-versions

pgj · 2023-11-21T13:07:25Z

Makefile

+
+
+define CONTRIBUTE_SHELL_SETUP
+  We detected $(CURRENT_SHELL) running on $(CURRENT_OS). Unfortunatelly


s/Unfortunatelly/Unfortunately/

Fixed in 42827b4

Makefile

pgj · 2023-11-21T13:12:28Z

Makefile

@@ -0,0 +1,290 @@
+.PHONY: help
+# target: help - Print this help


That is nice, I am glad you made available it here too.

README.md

pgj · 2023-11-21T13:28:55Z

@pgj Would it negatively impact your work on CI if I merge it?

No, I do not think so.

Running Clouseau in the CouchDB CI (and the respective developer setup) is supported through the releases section of this repository, i.e. downloading and unpacking pre-built JARs. It does not have to deal with the compilation. This makes launching the Clouseau nodes faster, can work with JRE 8, depends on the JRE itself, in exchange for not being able to serve development versions from the source locally. For that, one has to launch Clouseau as suggested in this PR for example, and separately run CouchDB configured for looking for clouseauN.

iilyak force-pushed the add-asdf-managed-tooling branch from dbd29a0 to 64eae51 Compare November 5, 2021 14:50

jaydoane reviewed Nov 12, 2023

View reviewed changes

iilyak added 6 commits November 20, 2023 11:22

Setup asdf and direnv managed development environment

0d529a4

Now `cd` into the project directory would activate correct versions of build dependencies.

Replace make run with make clouseau{1,2,3} targets

06565f2

Add 'make clean'

7c9a89e

Fix launcher name for 'make clouseau{1,2,3}'

c13699f

Modernize setup

6932460

Add check-epmd

0963ee0

iilyak force-pushed the add-asdf-managed-tooling branch from c99e60e to 0963ee0 Compare November 20, 2023 19:40

iilyak commented Nov 20, 2023

View reviewed changes

Add empty line at the end of a Makefile

d814b41

jaydoane approved these changes Nov 20, 2023

View reviewed changes

Add +dependency-reduced-pom.xml to .gitignore

6e41107

pgj reviewed Nov 21, 2023

View reviewed changes

.tool-versions Show resolved Hide resolved

pgj reviewed Nov 21, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

pgj reviewed Nov 21, 2023

View reviewed changes

Makefile

@@ -0,0 +1,290 @@

.PHONY: help

# target: help - Print this help

Copy link

Contributor

pgj Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is nice, I am glad you made available it here too.

pgj reviewed Nov 21, 2023

View reviewed changes

README.md Show resolved Hide resolved

iilyak added 5 commits November 21, 2023 12:27

Add direnv to .tool-versions

8987d6e

Colapse redundant targets

5e95fd5

Add WITH_COOKIE support

8099855

Use pgrep instead of lsof

e362d87

Fix typo in documentation

42827b4

pgj approved these changes Nov 22, 2023

View reviewed changes

iilyak merged commit af7e555 into master Nov 22, 2023
1 check passed

iilyak deleted the add-asdf-managed-tooling branch November 22, 2023 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup asdf and direnv managed development environment #44

Setup asdf and direnv managed development environment #44

iilyak commented Nov 5, 2021

tonysun83 commented Nov 6, 2021

jaydoane left a comment

jaydoane Nov 10, 2023

iilyak Nov 20, 2023

jaydoane Nov 10, 2023

pgj Nov 19, 2023

pgj Nov 21, 2023

iilyak Nov 21, 2023

iilyak Nov 20, 2023

pgj Nov 21, 2023

jaydoane left a comment

iilyak commented Nov 21, 2023

pgj Nov 21, 2023

iilyak Nov 21, 2023

pgj Nov 21, 2023

pgj commented Nov 21, 2023



		define CONTRIBUTE_SHELL_SETUP
		We detected $(CURRENT_SHELL) running on $(CURRENT_OS). Unfortunatelly

		@@ -0,0 +1,290 @@
		.PHONY: help
		# target: help - Print this help

Setup asdf and direnv managed development environment #44

Setup asdf and direnv managed development environment #44

Conversation

iilyak commented Nov 5, 2021

tonysun83 commented Nov 6, 2021

jaydoane left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaydoane left a comment

Choose a reason for hiding this comment

iilyak commented Nov 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgj commented Nov 21, 2023