chore: add metric on the count of NativeFSLocks held #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
reviewed
Jun 15, 2023
pgj
force-pushed
the
count-nativefslocks
branch
2 times, most recently
from
2fec4c1 to
8967d98
Compare
rnewson
reviewed
Jun 19, 2023
rnewson
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
remember that https://github.com/cloudant/chef-repo/blob/master/cookbooks/collectd/files/default/clouseau.java will need enhancing to get this new value into the metric system.
rnewson
reviewed
Jun 19, 2023
Lucene 4.6 is known to leak locks when an exception hits the rollback of an index writer. Introduce an optional metric on the size of the internal store that tracks the currently held NativeFSLocks to be able to assess its severity in practice. The method is specific to the Lucene internals and it uses Java reflection to extract the data as it is officially not accessible.
rnewson
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 4.6 is known to leak locks when an exception hits the rollback of an index writer. Introduce an optional metric on the size of the internal store that tracks the currently held
NativeFSLocks to be able to assess its severity in practice.The method is specific to the Lucene internals and it uses Java reflection to extract the data as it is officially not accessible.