Adding the provider #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fabi200123
commented
Feb 2, 2024
fabi200123
commented
- Adding the GCP External Provider
- Update README.md
gabriel-samfira
requested changes
Feb 4, 2024
There was a problem hiding this comment.
Just a few small comments. I have some doubts in regards to the startup script approach on Linux.
- The runner user needs to be part of the "admin" group and be able to use passwordless sudo
- The sudo user must exist
- curl and tar must be installed
Normally, the package management and user creation management is done by cloud-init, but if we can;t leverage it here, we need to make sure we have a robust enough startup script that it can take care of all the dependency on our own.
gabriel-samfira
requested changes
Feb 9, 2024
| // Create user 'runner' if it doesn't exist; '|| true' to ignore if user already exists | ||
| "sudo useradd -m " + defaults.DefaultUser + " || true", | ||
| // Create the runner home directory if it doesn't exist | ||
| "sudo mkdir -p /home/" + defaults.DefaultUser, |
There was a problem hiding this comment.
You also need to chown runner:runner -R /home/runner.
There was a problem hiding this comment.
This is done already in the generated script:
sendStatus "enabling runner service"
cp /home/runner/actions-runner/bin/runsvc.sh /home/runner/actions-runner/ || fail "failed to copy runsvc.sh"
sudo chown runner:runner -R /home/runner || fail "failed to change owner"
sudo systemctl daemon-reload || fail "failed to reload systemd"
sudo systemctl enable $SVC_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.