Adding extra-spec SSH Keys #24
Conversation
fabi200123
force-pushed
the
add-ssh-keys
branch
3 times, most recently
from
8a7406f to
36ece9f
Compare
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| **NOTE**: The `custom_labels` and `network_tags` must meet the [GCP requirements for labels](https://cloud.google.com/compute/docs/labeling-resources#requirements) and the [GCP requirements for network tags](https://cloud.google.com/vpc/docs/add-remove-network-tags#restrictions)! | ||
|
|
||
| **NOTE**: The `ssh_keys` add the option to [connect to an instance via SSH](https://cloud.google.com/compute/docs/instances/ssh) (either Linux or Windows). After you added the key as `username:ssh_public_key`, you can use the `private_key` to connect to the Linux/Windows instance via `ssh -i private_rsa username@instance_ip`. |
There was a problem hiding this comment.
Do the images need any specific packages pre-installed? Is there a quick howto you can include in the README?
There was a problem hiding this comment.
Afair, for Linux all images have ssh and for Windows the packages needed are already installed if there are any ssh keys sent as extra-specs -> https://github.com/cloudbase/garm-provider-gcp/pull/24/files#diff-fd6fb078945fce9b41e3aced4a0cb03cf47c4d318e2423733b23c741b30b7975R178
There was a problem hiding this comment.
I considered that if you want to use ssh keys on Windows, you want to have ssh enabled and installed on the instance
There was a problem hiding this comment.
it's worth adding a note that this also works on Windows, if the needed packages are pre-installed in the image.
There was a problem hiding this comment.
Mentioned at the end of the NOTE that the provider installs on the instance google-compute-engine-ssh and enables ssh if a ssh key is sent as extra-spec
Adding the extra-spec option for SSH Keys to allow users to add their own ssh-keys to the Garm instances