Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blueprint 02-At scale] Migration to helm-openldap/openldap-stack-ha (part I) #140

Merged
merged 41 commits into from
May 21, 2024

Conversation

carlosrodlop
Copy link
Collaborator

@carlosrodlop carlosrodlop commented May 15, 2024

@carlosrodlop carlosrodlop requested a review from a team as a code owner May 15, 2024 16:57
@carlosrodlop carlosrodlop changed the title [LDAP] MIigration to helm-openldap/openldap-stack-ha [LDAP] Migration to helm-openldap/openldap-stack-ha May 15, 2024
@carlosrodlop carlosrodlop marked this pull request as draft May 15, 2024 17:11
blueprints/02-at-scale/main.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/outputs.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/outputs.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/outputs.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/outputs.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/README.md Outdated Show resolved Hide resolved
blueprints/02-at-scale/README.md Outdated Show resolved Hide resolved
carlosrodlop and others added 10 commits May 15, 2024 19:34
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Copy link
Collaborator

@kellie-freeman kellie-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -66,6 +66,15 @@ locals {

cbci_agent_podtemplname_validation = "maven-and-go-ondemand"

global_password = random_string.global_pass_string.result
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use a change trigger to allow someone to rotate the password every once in a while?

variable "change_trigger" {
  description = "Change this value to generate a new random string"
  default     = "initial"
}

resource "random_string" "global_pass_string" {
  length  = 16
  special = false
  upper   = true
  lower   = true

  keepers = {
    change_trigger = var.change_trigger
  }
}

Copy link
Collaborator Author

@carlosrodlop carlosrodlop May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sboardwell Thanks for your review! :)

Avoid hardcoding secrets is a must and it needs to be handle since you ran this Quickstart for the very first time (day 0). See as example the first admin secret when you make a fresh installation for Jenkins CI.

Regarding rotating secrets (although is a best practice) I believe it is something you need done once you are ready to extend from this blueprint towards your custom blueprint (day 1). There are many other things to do in that list, for example: Deploying the cluster in your own existing VPC or EKS, updating the Authentication Realm, etc.

@carlosrodlop carlosrodlop changed the title [LDAP] Migration to helm-openldap/openldap-stack-ha [Blueprint 02-At scale] Migration to helm-openldap/openldap-stack-ha: Avoid hardcoded secrets in ldif file May 16, 2024
Copy link
Collaborator

@kellie-freeman kellie-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few minor suggested changes for comments. Please implement as you see fit.

blueprints/02-at-scale/k8s/openldap-stack-values.yml Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/k8s/openldap-stack-values.yml Outdated Show resolved Hide resolved
carlosrodlop and others added 3 commits May 20, 2024 22:58
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
givenname: developer_1
sn: Developer 1
displayname: Developer User 1
mail: developer.1@gmail.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that these will are real email addresses. I will create an issue to offer a replacement here. Either custom domain, or potentially even a + address solution such as myuser+dev1@acme.org, etc.

@carlosrodlop carlosrodlop marked this pull request as ready for review May 21, 2024 08:09
@carlosrodlop carlosrodlop added enhancement New feature or request security labels May 21, 2024
@carlosrodlop carlosrodlop merged commit 4a7dc29 into develop May 21, 2024
1 of 3 checks passed
@carlosrodlop carlosrodlop changed the title [Blueprint 02-At scale] Migration to helm-openldap/openldap-stack-ha: Avoid hardcoded secrets in ldif file [Blueprint 02-At scale] Migration to helm-openldap/openldap-stack-ha (part I) May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants