Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 3.17821.0] COE Review #150

Merged
merged 119 commits into from
May 23, 2024
Merged

[Release 3.17821.0] COE Review #150

merged 119 commits into from
May 23, 2024

Conversation

carlosrodlop
Copy link
Collaborator

No description provided.

carlosrodlop and others added 30 commits May 8, 2024 15:08
@carlosrodlop
CI: same values as main
406ca44
@kellie-freeman
Minor copy edits to recently revised docs.
4f939ca
@github-actions
terraform-docs: automated action
e59c816
@kellie-freeman
Fixing admonitions in lists and minor copy edits
283a9c1
@kellie-freeman
Minor edits.
5e06ffa
@kellie-freeman
Merge pull request #139 from cloudbees/copy-edits
b55e6f5 
Minor copy edits to recently revised docs.
@carlosrodlop
Addressing #72
fe17ca1
@carlosrodlop
Merge branch 'develop' of github.com:cloudbees/terraform-aws-cloudbee…
90e32d3 
…s-ci-eks-addon into develop
@carlosrodlop
Addressing #72
2461d52
@carlosrodlop
Adding main for ci
81d56f5
@carlosrodlop
Adding comments from Kelly
5b75d88
@carlosrodlop
fix line
7b03742
@github-actions
terraform-docs: automated action
152f194
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/README.md
87acb13 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/README.md
812eb76 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@github-actions
terraform-docs: automated action
2057eb3
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/outputs.tf
f507f8b 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/outputs.tf
a8f8311 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/outputs.tf
b0ccb68 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/outputs.tf
3094544 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@github-actions
terraform-docs: automated action
643bcfc
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/main.tf
3c5d134 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop
Preparing bundle
0072ba3
@carlosrodlop
Removing old secret hardcoded in the file
44d2178
@carlosrodlop
Replacing osixia-openldap by openldap-stack
8da46a7
@carlosrodlop
Merge branch 'ldap' of github.com:cloudbees/terraform-aws-cloudbees-c…
4457a03 
…i-eks-addon into ldap
@carlosrodlop
Removing osixia-ldap
ea28c16
@carlosrodlop
Casc. Test ldap password
2112e4b
@carlosrodlop
casc test
b3670a0
@carlosrodlop
Casc: Adding Ldap configuration for Example Org
2956470
@carlosrodlop carlosrodlop requested a review from a team as a code owner May 23, 2024 07:19
@carlosrodlop carlosrodlop added the documentation Improvements or additions to documentation label May 23, 2024
@carlosrodlop carlosrodlop changed the title COE Review [Release 3.17821.0] COE Review May 23, 2024
kellie-freeman
kellie-freeman reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@kellie-freeman kellie-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a few minor suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
blueprints/02-at-scale/variables.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/variables.tf Outdated Show resolved Hide resolved
blueprints/02-at-scale/README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
carlosrodlop and others added 14 commits May 23, 2024 16:24
@carlosrodlop @kellie-freeman
Update CONTRIBUTING.md
f19e330 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update CONTRIBUTING.md
3d35f97 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update CONTRIBUTING.md
85299ae 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update CONTRIBUTING.md
990455f 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update CONTRIBUTING.md
07d6585 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/variables.tf
b39a53f 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@github-actions
terraform-docs: automated action
e069d2a
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/README.md
6ebd8e3 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update blueprints/02-at-scale/variables.tf
e3814bf 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@carlosrodlop @kellie-freeman
Update variables.tf
ccc2130 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@github-actions
terraform-docs: automated action
1767602
@github-actions
terraform-docs: automated action
02415b6
@carlosrodlop @kellie-freeman
Update variables.tf
0e9f2e5 
Co-authored-by: Kellie Freeman <80066741+kellie-freeman@users.noreply.github.com>
@github-actions
terraform-docs: automated action
76b6ea5
kellie-freeman
kellie-freeman approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@kellie-freeman kellie-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlosrodlop carlosrodlop merged commit ccf4ab0 into main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellie-freeman kellie-freeman kellie-freeman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosrodlop @kellie-freeman