Azure quickstart samples #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/terraform into AzureQuickstartSamples
|
@echuvyrov Why does this PR have azurerm provider and quickstart template commits in it? It may be better to separate them as they are different concerns. It is more likely for azurerm provider changes to be merged in the upstream repo if they are separate from the quickstart template commits. |
Closed
|
@paulbouwer I agree and the idea was to make QuickStart PR separate. I still need to make the templates consistent with best practices doc that you authored, then I will clean up this PR to contain only the templates. |
|
Good call on |
|
@echuvyrov are you going to update this ? |
|
use the CI pipeline like the other sample changes so we have quality maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.