Feature: add abort method to result object #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method throws a
FailedResultException
if the result is a failure; otherwise it does nothing. This means the following:can be rewritten as:
This PR also changes the
ResultInterface::value()
method to throwFailedResultException
if attempting to get a value from a failed result. Previously it threw aContractException
- but the failed result exception makes more sense as it contains the originating result.