Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getResourceLinks function #643

Closed
KierynAnnette opened this issue Feb 6, 2024 · 3 comments
Closed

getResourceLinks function #643

KierynAnnette opened this issue Feb 6, 2024 · 3 comments
Assignees

Comments

@KierynAnnette
Copy link
Contributor

Looks like this function can no longer be used to override the high level links in the schema. Has this been changed to something else?

Adding:

public function getResourceLinks(mixed $resource): iterable { return []; }

no longer removes the high level links in the response.

@lindyhopchris
Copy link
Member

@KierynAnnette thanks for raising this.

I've attempted to fix on #644

Can you give it a go and let me know if it works?

composer require "cloudcreativity/laravel-json-api:dev-issue643"

@lindyhopchris lindyhopchris self-assigned this Feb 10, 2024
@KierynAnnette
Copy link
Contributor Author

@lindyhopchris I am only using v5 at the moment. But I applied your changes to that version and I can remove links and add my own. Looks good to me. Thanks

@lindyhopchris
Copy link
Member

Thanks! I've merged this into v6 and tagged v6.1.0 so whenever you upgrade your Laravel version you'll be able to get these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants