Fix bugs in script/release-publish. #42
Conversation
| @@ -80,7 +80,7 @@ set -x | |||
| VERSION="$(command cat ${ROOT}/include/version)" \ | |||
| || error_exit "Cannot find release version (${ROOT}/include/version)" | |||
| CURRENT_BRANCH="$(git rev-parse --abbrev-ref HEAD)" | |||
| if RELEASE_BRANCH_SHA="$(git rev-parse origin/${CURRENT_BRANCH})"; then | |||
| if RELEASE_BRANCH_SHA="$(git rev-parse upstream/${CURRENT_BRANCH})"; then | |||
There was a problem hiding this comment.
Don't change this, the git-remote upstream only exists in your local, in CI "origin" is pointed to cloudendpoints/esp.
There was a problem hiding this comment.
This doesn't get run on jenkins, does it?
It should be upstream not origin.
There was a problem hiding this comment.
Ah, yo u are right, but I'm not convinced it should be "upstream", the name "upstream" is just a convention and not git standard.
Probably use git ls-remote --heads https://github.com/cloudendpoints/esp ${CURRENT_BRANCH}? Need to process the output a bit though.
There was a problem hiding this comment.
No, this is only run manually by release engineer.
Yes, by convension it is "upstream". "origin" is your fork which may not have v1.0.x branch yet.
This is just for convenient check. Even if your "upstream" remote is not called with the name, it is OK, the script will just print warning.
* Fix bugs in script/release-publish. (#42) * Change script/release_tag_git to use upstream. * Update release-tag-git to use absolute repo
No description provided.