Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for PVC Base and ECS cluster on AWS IaaS #143

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Jun 4, 2024

No description provided.

jimright added 3 commits May 31, 2024 21:21
Signed-off-by: Jim Enright <jenright@cloudera.com>
Signed-off-by: Jim Enright <jenright@cloudera.com>
Signed-off-by: Jim Enright <jenright@cloudera.com>
@jimright jimright added the enhancement New feature or request label Jun 4, 2024
@jimright jimright requested a review from a team June 4, 2024 10:36
Signed-off-by: Jim Enright <jenright@cloudera.com>
@@ -0,0 +1,2 @@
localhost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License...

@@ -0,0 +1,5 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License...

Signed-off-by: Jim Enright <jenright@cloudera.com>
@jimright jimright requested a review from wmudge June 5, 2024 09:08
@rsuplina
Copy link

rsuplina commented Jun 5, 2024

Tested the deployment, ✅ "works on my Machine"

@clevesque
Copy link
Contributor

a few notes on this example:
Can we avoid hardcoding instance type, instance counts, disk sizes/types and ami types inside the terraform config files? Would like to have the option parameterize those values and pass in from definition.yml
Would like to use a ElasticIP on the bastion, instead of transient public IP.
ty

@wmudge wmudge merged commit 264db5f into cloudera-labs:devel Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants