Move DFX Beta implementation to GA process #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cdpy: * Rework cdpy/df to use the 'service' nomenclature instead of 'environment' for DataFlow * Allow separate submission of a name, env_crn, or df_crn for filtering the list of enabled DataFlow services * Allow submission of an env_crn or df_crn for the description of a Dataflow Service, as you cannot know the df_crn during creation until it is actually created * Standardise on use of df_crn for the service crn in DataFlow to provide differentiation from the env crn and other crns in CDP * Add new service enablement parameters to the dfx enable_service call * Add new terminate option to the DFX disable_service call * Change delete_environment to reset_service to reflect new usage * Squelch 403 response on describing a recently deleted Dataflow Service while it is being cleaned up cloudera.cloud: * renamed df.py to df_service.py to reflect that other DataFlow modules for Deployments will be needed in future * Include changes to submission parameters and method names for 'cdp df' calls in cdpy * Modify enable and disable service logic to match new methods and parameters * df_info now supports name, df_crn, or env_crn for filtering results * env_info once again checks for DataFlow during detailed Environment information collection * Added input validation for DataFlow service creation cloudera.exe: * Added defaults handling for new DataFlow submission parameters * renamed various methods and parameters to reflect updated DataFlow service naming and options Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
This was referenced Sep 15, 2021
cmperro
requested changes
Oct 5, 2021
wmudge
approved these changes
Oct 5, 2021
| @@ -436,7 +436,7 @@ def process(self): | |||
| for this_env in self.environments: | |||
| df = None | |||
| # Removing until DF is GA so we are not dependent on Beta functionality | |||
| # df = self.cdpy.df.describe_environment(this_env['crn']) | |||
| df = self.cdpy.df.list_services(env_crn=this_env['crn']) | |||
There was a problem hiding this comment.
Currently safe delete of an environment relies on this functionality, agree that it should be cleaned up to not need it but I don't want to cross the streams.
Add terminate option to docs for df_service.py Add additional options to examples/cdf for df service Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
cmperro
approved these changes
Oct 13, 2021
cmperro
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies:
cloudera-labs/cdpy#30
cloudera.cloud:
Signed-off-by: Daniel Chaffelson chaffelson@gmail.com