Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-controller code in 'module_utils/cm_utils' #136

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Oct 4, 2023

Move code into new 'cm_controller_utils.py' file and update imports.

Closes #135

@wmudge wmudge added the bug Something isn't working label Oct 4, 2023
@wmudge wmudge added this to the Release 4.0.1 milestone Oct 4, 2023
@wmudge wmudge requested a review from a team October 4, 2023 17:43
@wmudge wmudge changed the base branch from main to devel October 4, 2023 17:43
@wmudge wmudge marked this pull request as draft October 4, 2023 17:47
@wmudge wmudge marked this pull request as ready for review October 4, 2023 17:47
@wmudge
Copy link
Member Author

wmudge commented Oct 4, 2023

PR didn't trigger the right checks, will close and reopen.

@wmudge wmudge closed this Oct 4, 2023
@wmudge wmudge reopened this Oct 4, 2023
…roller_utils.py' file

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge force-pushed the fix/cm_utils-controller-code branch from 090baf7 to 385dd4c Compare October 5, 2023 14:02
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit ec03102 into cloudera-labs:devel Oct 5, 2023
4 checks passed
@wmudge wmudge deleted the fix/cm_utils-controller-code branch October 5, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validated
Development

Successfully merging this pull request may close these issues.

Update cm_utils.py to not contain controller-only code
2 participants