some models for dbt-impala-example are not appearing in Hue when adapted to run with dbt-spark-livy adapter #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted to run with dbt-spark-livy adapter Internal Ticket: https://jira.cloudera.com/projects/DBT/issues/DBT-124 Synopsis: When debuging the above ticket, the dbt logs indicated that there was an error in list_relations_without_caching indicating a NoneType was passed to the macro. Further it was observed that when an actual error by SQL executing in the warehouse was thrown, the error was siliently ignored. This PR addresses this issue. Testplan: Clone and sucessfully execute dbt seed and dbt run for the project https://github.com/TapasSenapati/dbt-spark-example
|
LGTM if we have tested that json object is logged properly in case of an actual error/exception. Also might need to figure other places at which this could happen. But that is for a separate day and ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Ticket: https://jira.cloudera.com/projects/DBT/issues/DBT-124
Synopsis: When debugging the above ticket, the dbt logs indicated that there was an error in list_relations_without_caching indicating a NoneType was passed to the macro.
Further it was observed that when an actual error by SQL executing in the warehouse was thrown, the error was silently ignored.
This PR addresses this issue.
Testplan:
Clone and successfully execute dbt seed and dbt run for the project https://github.com/TapasSenapati/dbt-spark-example