[Trino] Table/database names starting with digit should inclosed with double quotes #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl29
requested review from
wing2fly,
amitsrivastava,
JohanAhlen,
ranade1,
athithyaaselvam and
Harshg999
JohanAhlen
approved these changes
May 13, 2024
| @@ -90,21 +87,24 @@ def get_auth_password(self): | |||
| else DEFAULT_AUTH_PASSWORD.get() | |||
| ) | |||
|
|
|||
| def _format_database(self, database): | |||
| parts = database.split('.') | |||
| database = '"' + '"."'.join(parts) + '"' | |||
There was a problem hiding this comment.
Shouldn't we make sure only formats it once? I.e. not if it's already formatted..
| def _get_select_query(self, database, table, column=None, operation=None, limit=100): | ||
| if operation == 'hello': | ||
| statement = "SELECT 'Hello World!'" | ||
| else: | ||
| column = '%(column)s' % {'column': column} if column else '*' | ||
| database = self._format_database(database) | ||
| column = '"%(column)s"' % {'column': column} if column else '*' |
| statement = textwrap.dedent('''\ | ||
| SELECT %(column)s | ||
| FROM %(database)s.%(table)s | ||
| FROM %(database)s."%(table)s" |
wing2fly
reviewed
Jun 21, 2024
| import time | ||
| import logging |
There was a problem hiding this comment.
This seems not using anywhere in the file
| @@ -47,7 +45,7 @@ def decorator(*args, **kwargs): | |||
| except RestException as e: | |||
| try: | |||
| message = force_unicode(json.loads(e.message)['errors']) | |||
| except: | |||
| except Exception as e: | |||
There was a problem hiding this comment.
Should this change the character to not shadowed by the previous exception, like Exception as ex?
|
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?