Do not install VM extensions when var.allow_extension_operations is false
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonwhiskers
requested review from
rswrz,
lixhunter and
Phil-Thoennissen
as code owners
2 tasks
rswrz
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Please also add a note to the description of the extensions variable about its dependency on the allow_extension_operations variable. Make sure it is clear that the list of extension names in the extensions variable will be ignored if allow_extension_operations is set to true.
rswrz
changed the title
var.allow_extension_operations is false
Signed-off-by: Melody Sofia Eroshevich <se@cloudeteer.de>
Signed-off-by: Melody Sofia Eroshevich <se@cloudeteer.de>
neonwhiskers
force-pushed
the
36-bug-allow_extension_operations-does-not-properly-control-creation-of-extensions
branch
from
dde77de to
4668001
Compare
rswrz
requested changes
Oct 16, 2024
Signed-off-by: Melody Sofia Eroshevich <se@cloudeteer.de>
neonwhiskers
force-pushed
the
36-bug-allow_extension_operations-does-not-properly-control-creation-of-extensions
branch
from
466c3cd to
24d4e59
Compare
rswrz
previously approved these changes
Oct 16, 2024
|
@Phil-Thoennissen, as discussed in our weekly, please ad a unit test for this. cc: @lixhunter |
Phil-Thoennissen
force-pushed
the
36-bug-allow_extension_operations-does-not-properly-control-creation-of-extensions
branch
2 times, most recently
from
2d90050 to
e95c2ff
Compare
Signed-off-by: philthoennissen <pth@cloudeteer.de>
Phil-Thoennissen
force-pushed
the
36-bug-allow_extension_operations-does-not-properly-control-creation-of-extensions
branch
from
e95c2ff to
1abef35
Compare
lixhunter
approved these changes
Oct 22, 2024
Phil-Thoennissen
deleted the
36-bug-allow_extension_operations-does-not-properly-control-creation-of-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the for_each block to dynamically control extension creation.