Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close input stream on CloudEventHttpMessageReader fix #420 #421

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

joke
Copy link
Contributor

@joke joke commented Oct 15, 2021

Hi,

the input stream has not been closed correctly.

Fixes #420

@pierDipi
Copy link
Member

pierDipi commented Nov 3, 2021

Hi @joke, tests are failing, would you mind taking a look at them?

Signed-off-by: Joke de Buhr <joke.debuhr@eventim.de>
@joke
Copy link
Contributor Author

joke commented Nov 3, 2021

@pierDipi done

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pierDipi pierDipi merged commit a94bc5c into cloudevents:master Nov 3, 2021
@pierDipi pierDipi added this to the 2.3 milestone Dec 1, 2021
pierDipi pushed a commit to pierDipi/sdk-java that referenced this pull request Dec 21, 2021
Signed-off-by: Joke de Buhr <joke.debuhr@eventim.de>
pierDipi pushed a commit to pierDipi/sdk-java that referenced this pull request Dec 21, 2021
Signed-off-by: Joke de Buhr <joke.debuhr@eventim.de>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi pushed a commit to pierDipi/sdk-java that referenced this pull request Dec 21, 2021
Signed-off-by: Joke de Buhr <joke.debuhr@eventim.de>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi added a commit that referenced this pull request Dec 21, 2021
Signed-off-by: Joke de Buhr <joke.debuhr@eventim.de>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Joke de Buhr <joke@xckk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring WebFlux: LEAK: ByteBuf.release() was not called
2 participants