-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct url to naming conventions. #477
Set correct url to naming conventions. #477
Conversation
Would you mind expanding on the why? |
It might be faster, although, with the expected small size of an extension name, that might not be the case. It does limit the lines of code, but the complexity of a regex might outweigh that. |
Exactly, a proper benchmark should be added to validate the change isn't a perf regression for various cases. |
4e83137
to
15e7ad2
Compare
Thanks, I learned something today. Using the 3 extension names used in the unit test I quickly created a JMH test.
As the for loop implementation is almost 7 times faster, I reverted that part of the commit. |
Hi @gklijs, thanks for the fix and the quick update, can you please fix the DCO check as explained here: https://github.com/cloudevents/sdk-java/pull/477/checks?check_run_id=8348631721? |
Signed-off-by: Gerard Klijs <gerard.klijs@axoniq.io>
15e7ad2
to
daad91c
Compare
Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gklijs!
LGTM
Signed-off-by: Gerard Klijs <gerard.klijs@axoniq.io> Signed-off-by: alex-butcher <21243172+abutch3r@users.noreply.github.com>
I noticed the url in the Java doc was not correct. As it turns out using a regex is about ten times slower for this case, so I removed that part of the commit.