Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sphinx dependency out of package depedency #17

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

Lawouach
Copy link
Contributor

Signed-off-by: Sylvain Hellegouarch sh@defuze.org

  • Link to issue this resolves

#16

  • What I did

Moved the sphinx dependency to a new docs-requirements.txt

  • How to verify it
$ python setup.py build
$ cat cloudevents.egg-info/requires.txt
pbr!=2.1.0,>=2.0.0
  • One line description for the changelog

Remove Sphinx our of the package dependencies

@denismakogon
Copy link
Member

thank you for your help, really.
would you mind to add a new requirements file into tox as well (see https://github.com/cloudevents/sdk-python/blob/master/tox.ini#L14)

@Lawouach
Copy link
Contributor Author

Done. THough I don't fully understand why the build now fails.

tox.ini Outdated
@@ -11,7 +11,7 @@ basepython =
setenv = VIRTUAL_ENV={envdir}
usedevelop = True
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/test-requirements.txt
deps = -r{toxinidir}/test-requirements.txt -r{toxinidir}/docs-requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because tox considers -r{toxinidir}/test-requirements.txt -r{toxinidir}/docs-requirements.txt as a single string and pep fails to find a path like that.
so, it has to be like this:

deps = -r{toxinidir}/test-requirements.txt 
       -r{toxinidir}/docs-requirements.txt

here's similar multiline definition https://github.com/cloudevents/sdk-python/blob/master/tox.ini#L6

Contributes to cloudevents#16

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>
@Lawouach
Copy link
Contributor Author

Thanks. I wasn't aware of this.

Fixed now.

@denismakogon denismakogon merged commit 3084ca5 into cloudevents:master Apr 19, 2019
@denismakogon
Copy link
Member

I'll make a release soon.

@denismakogon
Copy link
Member

Done, look for 0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants