Remove old cloudevents specversion support (v01 and v02) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2020 11:50
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
grant
approved these changes
Jun 19, 2020
|
Need to fix samples and README |
added 2 commits
June 19, 2020 12:45
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
cumason123
force-pushed
the
remove-old-specversions
branch
from
223498d to
e3937a1
Compare
Signed-off-by: Curtis Mason <cumason@google.com>
grant
reviewed
Jun 22, 2020
| * MAJOR version increments when backwards incompatible changes is introduced. | ||
| * MINOR version increments when backwards compatible feature is introduced INCLUDING support for new CloudEvents version. | ||
| * PATCH version increments when a backwards compatible bug fix is introduced. | ||
|
|
|
@grant is this mergeable? |
cumason123
added a commit
to cumason123/sdk-python
that referenced
this pull request
Jun 23, 2020
) * removed tests/classes v01 and v02 Signed-off-by: Curtis Mason <cumason@google.com> * lint fixes Signed-off-by: Curtis Mason <cumason@google.com> * removed v02 from samples Signed-off-by: Curtis Mason <cumason@google.com> * removed v02 from README.md Signed-off-by: Curtis Mason <cumason@google.com> * removed v0.2 and v0.3 from README.md Signed-off-by: Curtis Mason <cumason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue this resolves
Remove support for v0.2 v0.1 events #35
What I did
Removed support for v01 and v02 cloudevent specs
How I did it
Removed tests and references to v01 and v02 event classes
One line description for the changelog
Remove old cloudevents specversion support