Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudevent fields type checking adjustments #96

Closed
wants to merge 2 commits into from

Conversation

cumason123
Copy link
Contributor

Fixes #95, #94, #92

Changes

#92:
moved

from cloudevents.sdk.converters import is_binary, is_structured

into

from cloudevents.http import is_binary, is_structured

#94
added

from cloudevents.exceptions import CloudEventMissingRequiredFields, CloudEventTypeErrorRequiredFields

#95:
BinaryHTTPCloudEventConverter.can_read
now checks 4 required fields instead of just 1

One line description for the changelog

cloudevent fields type checking adjustments

  • [*] Tests pass
  • [*] Appropriate changes to README are included in PR

Curtis Mason added 2 commits August 13, 2020 10:35
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
@cumason123 cumason123 closed this Aug 13, 2020
@cumason123 cumason123 deleted the is_binary_can_read_fix branch August 16, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant