-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed alignment of SDK governance files #1226
Conversation
@cloudevents/sdk-maintainers please review this. On today's call we agreed that we should be consistent with some of the governance aspects of the SDK and as part of that we should use the same names for common files. Please see if the proposed names are ok. If not, please speak up and propose an alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One slight tweak, but fundamentally I absolutely agree.
docs/SDK-GOVERNANCE.md
Outdated
## SDK Repository Requirements | ||
|
||
Each SDK must include the following: | ||
- a pointer to it's github repo from the CloudEvents [README.md](README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's => its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG I can't type that correctly! Seriously, I do know it!
docs/SDK-GOVERNANCE.md
Outdated
file | ||
- a README.md file with at least the following information: | ||
- a description of the SDK | ||
- a "Community" section with information about how to participate and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that "how to participate" is required here when CONTRIBUTING.md is also required... although it would be good to link to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I tweaked it - see if it's better now
Signed-off-by: Doug Davis <dug@microsoft.com>
@cloudevents/sdk-maintainers while I have your attention... please see this poll in the ce-sdk slack: https://cloud-native.slack.com/archives/CCXF3CBL1/p1694717251192769 |
Signed-off-by: Jon Skeet <jonskeet@google.com>
Signed-off-by: Jon Skeet <jonskeet@google.com>
Signed-off-by: Jon Skeet <jonskeet@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jcrossley3 @matzew @danbev @clemensv @lamw @Klaudioz @markpeek @linuxbasic @fabiojose @denismakogon @xSAVIKx @dan-j @helio-frota @lionelvillard @slinkydeveloper @Lazzaretti @dmilov @SimeonGerginov @embano1 @cumason123 @JoshLove-msft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Approved on the 9/21 call |
Related to cloudevents/spec#1226 Signed-off-by: Doug Davis <dug@microsoft.com>
Signed-off-by: Jon Skeet <jonskeet@google.com>
To address the governance review: cncf/tag-contributor-strategy#509